-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snackbar] Add customization example #11597
Conversation
@mbrn Thanks for your time. However, it doesn't align with our vision. We want to focus on core low-level components to enable people, like you, to build higher-level components like this one. In that sense, we are very happy to see this pull-request. Instead, what do you think of adding a customization demo to the Snackbar like we do with the Tabs, Button, Table or TextField? At the office, we have been overriding the Snackbar style to do something very close to what you are proposing. |
(please, don't close this pull-request to open another!) |
@oliviertassinari thanks for your reply. It's not problem for me. I can use this component as an independent repo and publish to npmjs.org. Maybe you can add this component to related-project page. Or we can add this to Paper component as customization demo. What do you think? Adding customization to snack-bar was my second idea after this one:). I need snack-bar which has status. So this is a good idea. |
@mbrn's icons were a bit more consistent: ( And the semi-transparency is a nice touch. |
@mbrookes Good feedback. I'm on it :). |
Thx @mbrookes & @oliviertassinari. Additionally we could add "info, success, warning" fields to Palette. In this way we can use these bars' color from theme. |
It's what we do at the office 👍. Users are free to do it on their side. |
[NotificationBar] component has been added